Dynamic created combo-box working on one form but not other, class module issue?

Thank you for having a read:

I have two forms with dynamically created comboboxes attempting to reference the same class module.

The first works as expected with the relevant code as follows:

Sub Reactions()

Dim clsComboBox As New cComboBox
Dim MyCBx As MSForms.ComboBox

Set m_colComboBoxEvents = New Collection

loop starts here

'other code

If MyFRMS < CInt(MyFill(UBound(MyFill))) Then
Set MyCBx = Me.Frame20.Controls.Add("Forms.ComboBox.1", "MyNCBX" & MyFRMS, True) 'adds combobox
With MyCBx
.Top = 330
.Left = 90 + (160 * (MyFRMS - 1))
.Width = 160
.Height = 20
.FontSize = 8
.FontName = "Times New Roman"
.ColumnCount = 2
.ColumnWidths = ",0"
.Value = "========================>"
End With
Set clsComboBox = New cComboBox
Set clsComboBox.Box = MyCBx
m_colComboBoxEvents.Add clsComboBox, CStr(m_colComboBoxEvents.Count + 1)

'other code

loop ends here

End Sub

Class module code here:

Option Explicit
Private WithEvents m_ComboBoxEvents As MSForms.ComboBox


Public Property Set Box(RHS As MSForms.ComboBox)


Set m_ComboBoxEvents = RHS


End Property
Private Sub m_ComboBoxEvents_Change()


If REACTIONS.Visible = True Then
Debug.Print "hELlO"


'\\ WHEN COMBOBOX CHANGES ON REACTION FORM IT PASSES THE CAPTION INFORMATION FOR THE BUTTONS.


If Len(Box.Name) = 7 Then REACTIONS.Frame20.Controls("MyNCBtn" & Right(Box.Name, 1)).Caption = Box.List(Box.ListIndex, 1) ' will only work until 9
If Len(Box.Name) = 8 Then REACTIONS.Frame20.Controls("MyNCBtn" & Right(Box.Name, 2)).Caption = Box.List(Box.ListIndex, 1) ' will work until 99


End If
Debug.Print "Hi"


If UFSTDRDS.Visible = True Then


MsgBox ("Hello")


End If




End Sub


Public Property Get Box() As MSForms.ComboBox
Set Box = m_ComboBoxEvents
End Property

On another form in the same workbook I am attempting to achieve a similar result using:

Sub Not_Working()

Dim clsComboBox As New cComboBox
Dim MyCBx As MSForms.ComboBox
Dim m_colComboBoxEvents As Collection ' If I remove this line I get variable undefined error in next line, but it is not required in the working code above
Set m_colComboBoxEvents = New Collection

Loop starts here

Set MyCBx = Me.MultiPage1.Pages(2).Controls.Add("Forms.ComboBox.1", "MyNCBox" & x, 1)
Dim MyCBxfill As Variant
MyCBxfill = ws1.Range("A1").CurrentRegion
With MyCBx
.Top = 280 + ((x - 1) * 30)
.Left = 250
.Width = 350
.Height = 20
.FontSize = 8
.FontName = "Times New Roman"
.ColumnCount = UBound(MyCBxfill, 2)
'.ColumnWidths = ",0"

.List = MyCBxfill

End With
Set clsComboBox = New cComboBox
Set clsComboBox.Box = MyCBx
m_colComboBoxEvents.Add clsComboBox, CStr(m_colComboBoxEvents.Count + 1)

Loop ends here
End Sub

The reactions code as seen in the class module "if reactions.visible" works fine and when I change those comboboxes the code in the if statement of the class module works and I get the debug.print of both "HeLio" and "Hi"... however nothing from the class code runs when I change the comboboxes on the second form using the not working code.

Any insight and improvement to the existing code would be appreciated.

Regards

Justin

Hi Roy, I was hoping it would be obvious that I was missing something from the code, I have attached a workbook.

From the Sheet labelled "FRONT" select "SHOW DIRECTORY"

Click on "REACHBACK" under select client.

Select "VIEW REACTIONS" then click the big green button.

At the bottom of the form that displays is the synthesis pathway in a list box, select it. Then select one of the pathways that appear in the listbox that appears along side.

Click on the Frame in the background (should be an image background), then select one of the comboboxes that appear and it should update the caption on the respective button below it. This is the working code, it uses the "REACTIONS" form, and the code is linked to the LBSELECT listbox on this form.

Now open the directory and select the "LAB TOOLS" client, then "STANDARDS PREPARATION" and click the green button.

On the multipage go to "MultiComponent Mix from Stock" and use the spin button a few times to increase the number in the label alongside. Click on the label to create the dynamic textboxes and comboboxes then make a selection from the combobox. This is the code that is not working, it is linked to the UFSTDRDS form and code is in the LMCMCOUNT label.

I know there are errors in the code elsewhere as well, this is still a first draft and I am working through and learning as I go. Any pointers much appreciated. At a later date I might pay for some input if it proves fit for purpose.

If you need me to clarify or highlight anything let me know.

See later post for correct workbook

Regards

Justin

Thank you Roy,

I cannot edit my post and would like to remove a couple of columns from one of the sheets... Would you mind allowing me to edit that post or if not I can let you know what to remove.

Justin

And again,

Sorry, I was a bit hasty with the previous versions. This one has everything removed that may cause me a headache.

Most data removed example.xlsb

If you could replace the previous version in the original post with this and remove the two previous versions from the site that would be great. Just some personal info that should have been removed.

Thank you for "Trashing" my post

Hi Roy,

I have cut this down to only the class module, the form that has the error and enough information for it to work.

I ran the dubug compile and it seems to be clear on this one, obviously not something I have done previously... I will have some fun working through that soon.

Regards
Justin

Test.xlsb

HI, I just cross posted this to : https://superuser.com/question…ut-not-other-class-module

Thank you Rory,

that has fixed the issue. I just checked the reactions form and the collections are declared at the top of the form code, I just did not translate correctly to the new form. I have been banging my head for days trying to work that out.

Brilliant Thank you...

You should have a "Buy Me a Coffee" option somewhere on the site.

Regards

Justin